Skip to content

.pytool/HostUnitTestCompilerPlugin: Return failure if dsc path is not… #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

.pytool/HostUnitTestCompilerPlugin: Return failure if dsc path is not… #11763

wants to merge 1 commit into from
+7 −2

Conversation

@cosmolai
Copy link
Contributor

@cosmolai cosmolai commented Nov 17, 2025 •
edited
Loading

Description

The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid.
This change returns failure if dsc path is not valid.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Verified if returns skipped if dsc path is empty.
Verified it returns failure if dsc path is not valid.

Integration Instructions

N/A

@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 950b3c1 to 24c3591 Compare November 17, 2025 04:27
@cosmolai cosmolai marked this pull request as ready for review November 17, 2025 05:57
@cosmolai
Copy link
Contributor Author

cosmolai commented Nov 17, 2025

@mdkinney please help to review this. thanks.

@Javagedes
Copy link
Contributor

Javagedes commented Nov 17, 2025

@cosmolai Please update the PR description, putting the main comments under the ## Description section, and filling out the rest of the sections.

Thanks,
Joey

@cosmolai
.pytool/HostUnitTestCompilerPlugin: Return failure if dsc path is not…
772e74a 
… valid

The HostUnitTestCompilerPlugin currently skips the package if the dsc path
described in .ci.yaml is not valid.

This change returns failure if dsc path is not valid.

Signed-off-by: Cosmo Lai <[email protected]>
@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 24c3591 to 772e74a Compare November 18, 2025 04:00
@tianocore-pr-automation
Copy link

tianocore-pr-automation bot commented Nov 18, 2025

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@cosmolai
Copy link
Contributor Author

cosmolai commented Nov 21, 2025

@cosmolai Please update the PR description, putting the main comments under the ## Description section, and filling out the rest of the sections.

Thanks, Joey

Updated. Let me know if any.

@Javagedes
Copy link
Contributor

Javagedes commented Nov 21, 2025

Approved. Will give it the weekend for others to review if they wish. Then will add the push tag. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Javagedes Javagedes Javagedes approved these changes

@lgao4 lgao4 Awaiting requested review from lgao4

@mdkinney mdkinney Awaiting requested review from mdkinney

@spbrogan spbrogan Awaiting requested review from spbrogan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cosmolai @Javagedes